Repository: Remove Backend() method #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
backend-cleanups
branch
from
d135ba1
to
bfd77c8
Compare
Only handling one specific error is not particularly useful.
RemoveUnpacked will eventually block removal of all filetypes other than snapshots. However, getting there requires a major refactor to provide some components with privileged access.
The migration modifies repository internals and thus should live within the repository package.
The migration will be removed after the next restic release anyways. Thus, there's no need for a clean implementation.
This allows the Lock function to access the backend, even once the Backend method is removed from the interface.
These will eventually be blocked as they do not delete Snapshots.
The cache cleanup pattern is also used in ListPack etc.
MichaelEischer
force-pushed
the
backend-cleanups
branch
from
bfd77c8
to
223aa22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR removes the
Backend()method from the repository. Thereby it is no longer possible to directly manipulate repository data structures. The main consequence is that code that touches repository internal data structures, must now live within therepositorypackage. It will also make it simpler in the future to get rid of the global repository interface as the interface is less nested.To allow this refactor, the PR adds a
RemoveUnpacked()method to the repository that currently allows deleting arbitrary files. This will change in a future PR, however, would require too much refactoring for now. In addition, the upgrade_repo_v2 migration and checker.checkPack have moved into the repository package.Was the change previously discussed in an issue or on the forum?
The roadmap for 0.17 contains a refactor to limit modifications of unpacked files through the repository API. This PR is a prerequisite for getting there.
Checklist
[ ] I have added tests for all code changes.[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.