Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
It adds basic support for empty passwords and may be a solution for #4326.
This is just a PoC, I haven't ever written a single Go line before.
Subcommands
init
andkey add|passwd
now support the flag--insecure-password
which disables the check for an empty password.restic
warns about it, though.Support for
RESTIC_PASSWORD_FILE
and coresponding CLI option has been added as well. You may user either an empty file or just/dev/null
.Was the change previously discussed in an issue or on the forum?
Not sure if it really fulfils (all of) the aims of #4326, but it may be a starting point.
Checklist
Nothing relevant is checked yet. This is just a prof of concept (for now). If there is a future for this, I am happy to do it right.
It have been tested only manually. Works on my machine™. ;)
changelog/unreleased/
that describes the changes for our users (see template).gofmt
on the code in all commits.