Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dynamic schedule set_schedule default persist #637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceshihao
Copy link

@ceshihao ceshihao commented Feb 2, 2018

To improve the incompatible problem #633

@carsonreinke
Copy link
Contributor

@ceshihao Totally agree with this. I believe this would be a breaking change with semantic versioning, so it would have to be included in v5.

There is some test failures from the default change, probably just simply need to set persist: false for this cases.

@carsonreinke carsonreinke added this to the Release v5.0.0 milestone Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants