added strict caching and leader replacement that minimizes interruption to event stream #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafaakin
previously approved these changes
Nov 3, 2022
|
Hi, @mustafaakin . Thanks I have a few more PRs coming. |
|
Of course, no worries. |
…used to query the state of the cache
xmcqueen
changed the title
xmcqueen
changed the title
|
maybe I should add a flag to make this optional. It could be something like --lazy-shutdown. |
4 tasks
|
Once #153 is merged, this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added strict cacheing where both the UID and the resourceVersion are used to query the state of the cache
see issue #19
Also added leader election code that has minimal downtime and minimal loss of events
and issue #24