fix: Use correct transport with loki #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mustafaakin - ping! Would love to get this into the mainline kubernetes-event-exporter if we can. We've been using it in a bit now and it's working well for us. |
|
Hello, I'll review outstanding repositories next week. If you have missed,
Resmo was acquired by JumpCloud so there was a delay in handling things.
…On Tue, Mar 26, 2024 at 7:20 PM Matt Farmer ***@***.***> wrote:
Hey @mustafaakin <https://github.com/mustafaakin> - ping! Would love to
get this into the mainline kubernetes-event-exporter if we can. We've been
using it in a bit now and it's working well for us.
—
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEHMYSGRUSQOR2FVFWPO3Y2F4JNAVCNFSM6AAAAABD43NBLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGQ4DGNRTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Mustafa Akin @ Resmo
|
|
Hey @mustafaakin - I hope all is going well with Resmo and JumpCloud. Want to circle back to this because we're continuing to have to run a fork to address this. I'm mindful that you're constrained by your available time, but want to ask: is there any hope of movement soon here? Cheers! |
|
Hi Yes! Sorry we neglected this project a bit. I'll review outstanding PRs today! I'll talk about mostly this project on Kubernetes Istanbul, this project is always in our interests. |
|
Hello, |
|
@mustafaakin Any update on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve issues with the loki sink not respecting the tls configuration. I updated this to match what the webhook sink is doing when configuring its transport.
fixes #127