Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all sinks add the trigger to controll sent or ignore event update,and make the code gci-ed #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wuzhuoquan
Copy link

if an event occur many times, It will only update the event fields like count and lastTimestamp.
By default kubernetes-event-exporter will ignore the eventUpdate and will not sent to the recivers.
If you Don't want to miss every event,you can use trigger sentUpdateEvent configurated in each sink to controll whether sent the event to the reciver.

@wuzhuoquan
Copy link
Author

According to this closed PR: #126 (comment)
This time I make the sentUpdateEvent trigger to to each sink.
And also make the code gci-ed with gci check.
Please check it.

@wuzhuoquan wuzhuoquan changed the title al sinks add the trigger to controll sent or ignore event update,and make the code gci-ed all sinks add the trigger to controll sent or ignore event update,and make the code gci-ed Dec 1, 2023
@mustafaakin
Copy link

This was a highly requested feature, so thanks, I'll review this soon. The only thing we need to be careful for on update events is setting IDs properly, so that underlying databases can update the item instead of growing it to eternity.

@wuzhuoquan
Copy link
Author

This was a highly requested feature, so thanks, I'll review this soon. The only thing we need to be careful for on update events is setting IDs properly, so that underlying databases can update the item instead of growing it to eternity.

hello? Do you have time to review and merge this pr?

@mustafaakin
Copy link

Sorry for late response. However as I said we need to ensure all the sinks have proper IDs set in their responses in order to merge this to avoid ever growing data in the sinks such as Elasticsearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants