Skip to content

Fix issue with invalid code when emitting typeof with a function. #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Fix issue with invalid code when emitting typeof with a function. #7643

merged 1 commit into from
Jul 14, 2025

Conversation

cristianoc
Copy link
Collaborator

Fixes #7641

@cristianoc cristianoc requested a review from cknitt July 14, 2025 09:21
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 14, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7643

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7643

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7643

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7643

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7643

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7643

commit: a4fa447

cknitt
cknitt approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

@cristianoc cristianoc merged commit 4e70537 into master Jul 14, 2025
27 checks passed
@cristianoc cristianoc deleted the typeof_parens branch July 14, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v12 - Js.typeof or Type.typeof of a @val external function would produce SyntaxError in runtime
2 participants
@cristianoc @cknitt