use TLS 1.2 to upload files to CDN using FTP (#7306)

rescript-lang · Feb 19, 2025 · fd1e7b8 · fd1e7b8
1 parent 5437d14
commit fd1e7b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@
 - Fix dot completion issue with React primitives. https://github.com/rescript-lang/rescript/pull/7292
 - Stdlib namespace for Core modules (fixes name clashes with user modules). https://github.com/rescript-lang/rescript/pull/7285
 - Fix runtime type check for Object in untagged variants when one variant case is `null`. https://github.com/rescript-lang/rescript/pull/7303
+- Fix files that were being truncated when sent to the CDN over FTP. https://github.com/rescript-lang/rescript/pull/7306
 
 #### :house: Internal
 

diff --git a/playground/upload_bundle.sh b/playground/upload_bundle.sh
@@ -32,7 +32,7 @@ fi
 PACKAGES=("compiler-builtins" "@rescript/react")
 
 echo "Uploading compiler.js file..."
-curl --ftp-create-dirs -T "${SCRIPT_DIR}/compiler.js" --ssl --netrc-file $NETRC_FILE ftp://${KEYCDN_SRV}/v${VERSION}/compiler.js
+curl --ftp-create-dirs -T "${SCRIPT_DIR}/compiler.js" --ssl --tls-max 1.2 --netrc-file $NETRC_FILE ftp://${KEYCDN_SRV}/v${VERSION}/compiler.js
 
 echo "---"
 echo "Uploading packages cmij files..."
@@ -43,7 +43,7 @@ do
 
   echo "Uploading '$SOURCE/cmij.js' to '$TARGET/cmij.js'..."
 
-  curl --ftp-create-dirs -T "${SOURCE}/cmij.js" --ssl --netrc-file $NETRC_FILE "${TARGET}/cmij.js"
+  curl --ftp-create-dirs -T "${SOURCE}/cmij.js" --ssl --tls-max 1.2 --netrc-file $NETRC_FILE "${TARGET}/cmij.js"
 done
 
 # we now upload the bundled stdlib runtime files
@@ -54,4 +54,6 @@ TARGET="ftp://${KEYCDN_SRV}/v${VERSION}/${DIR}"
 
 echo "Uploading '$SOURCE/*.js' to '$TARGET/*.js'..."
 
-find "${SOURCE}" -type f -name "*.js" -exec sh -c 'curl --ftp-create-dirs --ssl --netrc-file "$0" -T "$1" "${2}/$(basename "$1")"' "$NETRC_FILE" {} "$TARGET" \;
+# we use TLS 1.2 because 1.3 sometimes causes data losses (files capped at 16384B)
+# https://github.com/curl/curl/issues/6149#issuecomment-1618591420
+find "${SOURCE}" -type f -name "*.js" -exec sh -c 'curl --ftp-create-dirs --ssl --tls-max 1.2 --netrc-file "$0" -T "$1" "${2}/$(basename "$1")"' "$NETRC_FILE" {} "$TARGET" \;