list_item2
migration (part 2): convert all use of legacy list time to list_item2
#6377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Convert all current use of legacy list item to
list_item2
.The main part of that is ensuring that all list items are enclosed in a
list_item_scope
. For some "lone" list items, that means an ad hoc scope around only one item. Maybe this could be improved in the future.Part of a mini-series:
list_item2
migration (part 1): ensure background is painted on rounded pixels #6376list_item2
migration (part 2): convert all use of legacy list time tolist_item2
#6377list_item2
migration (part 3): renamelist_item2
tolist_item
#6378Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.