Skip to content

Clang 18 for everyone and everything #10110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jun 2, 2025

TODO: we need to patch loguru so that it passes clang18:

 FAILED: _deps/logurugitrepo-build/CMakeFiles/loguru.dir/loguru.cpp.o 
/Users/runner/work/rerun/rerun/.pixi/envs/cpp/bin/x86_64-apple-darwin13.4.0-clang++  -I/Users/runner/work/rerun/rerun/build/debug/_deps/logurugitrepo-src -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem /Users/runner/work/rerun/rerun/.pixi/envs/cpp/include -g -isysroot /Applications/Xcode_16.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -Werror -MD -MT _deps/logurugitrepo-build/CMakeFiles/loguru.dir/loguru.cpp.o -MF _deps/logurugitrepo-build/CMakeFiles/loguru.dir/loguru.cpp.o.d -o _deps/logurugitrepo-build/CMakeFiles/loguru.dir/loguru.cpp.o -c /Users/runner/work/rerun/rerun/build/debug/_deps/logurugitrepo-src/loguru.cpp
/Users/runner/work/rerun/rerun/build/debug/_deps/logurugitrepo-src/loguru.cpp:1328:4: error: 'snprintf' will always be truncated; specified size is 5, but format string expands to at least 6 [-Werror,-Wformat-truncation]
 1328 |                         snprintf(level_buff, sizeof(level_buff) - 1, "% 4d", static_cast<int8_t>(verbosity));
      |                         ^
1 error generated.

Switch all pixi things to clang 18, which I've confirmed is capable of linking latest mimalloc on all platforms (as opposed to the current clang 16 we're using).

@teh-cmc teh-cmc added 🦀 Rust API Rust logging API dependencies concerning crates, pip packages etc 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jun 2, 2025
Copy link

github-actions bot commented Jun 2, 2025

Latest documentation preview deployed successfully.

Result Commit Link
c680fdd https://landing-ja4x6c5q4-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc marked this pull request as draft June 2, 2025 08:31
Copy link

github-actions bot commented Jun 2, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
c680fdd https://rerun.io/viewer/pr/10110 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc
Copy link
Member Author

teh-cmc commented Jun 2, 2025

Will undraft once (if) we pass full CI.

@teh-cmc
Copy link
Member Author

teh-cmc commented Jun 2, 2025

@rerun-bot full-check

Copy link

github-actions bot commented Jun 2, 2025

@Wumpf Wumpf self-assigned this Jun 16, 2025
@Wumpf
Copy link
Member

Wumpf commented Jun 16, 2025

note that on MacOS we still have to use system-clang for some thing - very annoying but couldn't figure out how to get things to link otherwise, see #10214

@Wumpf
Copy link
Member

Wumpf commented Jun 16, 2025

happy to take this over when I have a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🦀 Rust API Rust logging API 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web build fails on macOS ("LLVM error: section too large")
2 participants