fix: use deviceId instead of uid for uninstallation event mapping #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
wrongsahil
requested changes
May 7, 2024
app/src/hooks/AuthHandler.ts
Outdated
| @@ -90,7 +90,6 @@ const AuthHandler: React.FC<{}> = () => { | |||
| Logger.timeLog("AuthHandler-blockingOperations", "START"); | |||
| const authData = getAuthData(user); | |||
| window.uid = user.uid; | |||
| localStorage.setItem("__rq_uid", user.uid); | |||
app/public/index.html
Outdated
| @@ -11,7 +11,8 @@ | |||
| window.location.href = 'https://app.requestly.io'; | |||
| } | |||
|
|
|||
| if ("https://app.requestly.io/goodbye/" === window.location.href) { const a = { api_key: "62ff1b46909e50358cfca0668d41f011", events: [{ user_id: localStorage.getItem("__rq_uid") || Math.random().toString(36).slice(2, 10), event_type: "extension_uninstalled" }] }, b = new Blob([JSON.stringify(a)]); navigator.sendBeacon("https://api2.amplitude.com/2/httpapi", b) } | |||
| const deviceId = localStorage.getItem("__rq_device_id") | |||
| if ("https://app.requestly.io/goodbye/" === window.location.href && deviceId) { const a = { api_key: "62ff1b46909e50358cfca0668d41f011", events: [{ device_id: deviceId, event_type: "extension_uninstalled" }] }, b = new Blob([JSON.stringify(a)]); navigator.sendBeacon("https://api2.amplitude.com/2/httpapi", b) } | |||
There was a problem hiding this comment.
We should use uid first and if it is not found, then we should use the deviceId.
app/public/index.html
Outdated
| @@ -11,7 +11,8 @@ | |||
| window.location.href = 'https://app.requestly.io'; | |||
| } | |||
|
|
|||
| if ("https://app.requestly.io/goodbye/" === window.location.href) { const a = { api_key: "62ff1b46909e50358cfca0668d41f011", events: [{ user_id: localStorage.getItem("__rq_uid") || Math.random().toString(36).slice(2, 10), event_type: "extension_uninstalled" }] }, b = new Blob([JSON.stringify(a)]); navigator.sendBeacon("https://api2.amplitude.com/2/httpapi", b) } | |||
| const deviceId = localStorage.getItem("__rq_device_id") | |||
| if ("https://app.requestly.io/goodbye/" === window.location.href && deviceId) { const a = { api_key: "62ff1b46909e50358cfca0668d41f011", events: [{ device_id: deviceId, event_type: "extension_uninstalled" }] }, b = new Blob([JSON.stringify(a)]); navigator.sendBeacon("https://api2.amplitude.com/2/httpapi", b) } | |||
There was a problem hiding this comment.
We need to set extension_uninstall_date attribute too on uninstall
There was a problem hiding this comment.
setting attributes is not available in the http api
app/public/index.html
Outdated
| @@ -11,7 +11,8 @@ | |||
| window.location.href = 'https://app.requestly.io'; | |||
There was a problem hiding this comment.
This file is deprecated when we shifter to vite. Please delete this file to avoid confusion in future
wrongsahil
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locally stored user id has many problems:
shifting to using the deviceId instead