EPMRPP-93641 migrate to Spring Boot 3 #1044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it is impossible to fix CVE-2020-29582 since it presents in every version of transitive kotlin dependency |
# Conflicts: # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties # jitpack.yml # jooq.gradle # project-properties.gradle
grabsefx
changed the title
APiankouski
reviewed
Jan 11, 2025
| @@ -128,9 +128,10 @@ public Optional<BinaryDataMetaInfo> saveAttachment(AttachmentMetaInfo metaInfo, | |||
| } catch (IOException e) { | |||
| LOGGER.error("Unable to save binary data", e); | |||
| } finally { | |||
| if (file instanceof CommonsMultipartFile) { | |||
| // TODO: uncomment and fix later !!! | |||
There was a problem hiding this comment.
What needs to be fixed?
There was a problem hiding this comment.
Thanks for pointing on this. I can asume that the previous purpose of this code was to handle temporary files created while preparing demodata, specificaly attachments for the logs. And since Spring libraries migrated to their own implementaion of file handling instead of apache libraries - this code is not releavant anymore and can be safely removed.
APiankouski
approved these changes
Jan 11, 2025
pbortnik
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made adjustments to support Spring Boot 3
Regenerated jooq classes with the latest generator version