feature(formatters): add JSONFormatter #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Squizzato <[email protected]>
squizzi
commented
Feb 5, 2025
|
|
||
| // Configure default fields. | ||
| prefixDefaultFieldClashes(data) | ||
| data["timestamp"] = entry.Time.Format("2006/01/02 15:04:05") |
There was a problem hiding this comment.
Should we use this same time format or should we stick to something more JSON-y?
Signed-off-by: Kyle Squizzato <[email protected]>
divolgin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
JSONFormatterbased on thelogrus.JSONFormatterimplementation. It updates the existing tests where we test theConsoleFormatterto test both formatters and adds a new test to test prefixing of fields.The intent for this is to use this formatter for logging in vandoor, specifically in https://github.com/replicatedhq/vandoor/pull/6859