Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking out when user says no #567

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix checking out when user says no #567

merged 2 commits into from
Mar 11, 2021

Conversation

bfirsh
Copy link
Member

@bfirsh bfirsh commented Mar 11, 2021

@andreasjansson
Copy link
Member

👍 when the tests pass

@andreasjansson andreasjansson self-requested a review March 11, 2021 19:47
@bfirsh
Copy link
Member Author

bfirsh commented Mar 11, 2021

test failures are #551, grr

@bfirsh
Copy link
Member Author

bfirsh commented Mar 11, 2021

Just gonna skip the broken pytorch lightning tests so we can get this in, which seems more important.

@bfirsh bfirsh merged commit b5db94e into replicate:main Mar 11, 2021
@bfirsh bfirsh deleted the im-afraid-i-cant-do-that branch March 11, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasjansson andreasjansson andreasjansson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfirsh @andreasjansson