Wandb fixes #25
Merged
Wandb fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
* Always log out (shouldn't be an issue but just in case) * Truncate long image file names * Catch all wandb exceptions
andreasjansson
force-pushed
the
wandb-fixes
branch
from
75a6315 to
b77d30a
Compare
|
|
||
| def finish(self): | ||
| with suppress(Exception): | ||
| wandb.finish() | ||
|
|
||
| def logout(self): | ||
| netrc_path = Path("/root/.netrc") |
There was a problem hiding this comment.
Directly manipulating the .netrc file is insecure and assumes a fixed path. Consider using environment variables or secure vaults for API key management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances wandb integration by ensuring proper logout, handling exceptions, and truncating long image file names.
Key points:
logoutmethod inWeightsAndBiasesClienttruncatefunction for image file namestrainfunction to handle exceptions and cleanupGenerated with ❤️ by ellipsis.dev