Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TOK as default value of trigger_word #24

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

zeke
Copy link
Member

@zeke zeke commented Sep 5, 2024

TOK is not a good default trigger word, because the latent space is already polluted with for it.

This PR proposes to remove the default, so users are forced to pick a unique trigger word.


From the Cog docs:

default: A default value to set the input to. If this argument is not passed, the input is required. If it is explicitly set to None, the input is optional.

@zeke zeke requested review from a team September 5, 2024 03:30
@zeke
Copy link
Member Author

zeke commented Sep 6, 2024

bump @andreasjansson @zsxkib @fofr

Copy link
Member

@andreasjansson andreasjansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@andreasjansson andreasjansson merged commit 1482c42 into main Sep 6, 2024
2 checks passed
@andreasjansson andreasjansson deleted the remove-TOK-as-default-value-of-trigger_word branch September 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants