Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move docs index/homepage file to main repo #28751

Merged
merged 9 commits into from May 10, 2024
Merged

docs: move docs index/homepage file to main repo #28751

merged 9 commits into from May 10, 2024

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Apr 30, 2024 •
edited

Changes

  • Move the homepage/index file to the main repository

Context

Also relies on another PR that deletes the homepage file from the docs repository:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose mentioned this pull request Apr 30, 2024
Merged
HonkingGoose
HonkingGoose commented Apr 30, 2024
View reviewed changes
docs/usage/index.md Show resolved Hide resolved
docs/usage/index.md Outdated Show resolved Hide resolved
viceice
viceice reviewed Apr 30, 2024
View reviewed changes
docs/usage/index.md Outdated Show resolved Hide resolved
viceice
viceice reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

docs/usage/index.md Show resolved Hide resolved
@viceice viceice requested a review from rarkins April 30, 2024 16:47
viceice
viceice previously approved these changes Apr 30, 2024
View reviewed changes
viceice
viceice reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the index.md from the new tests static files too

@HonkingGoose HonkingGoose requested a review from viceice May 1, 2024 13:30
viceice
viceice previously approved these changes May 2, 2024
View reviewed changes
@HonkingGoose HonkingGoose marked this pull request as ready for review May 6, 2024 09:40
HonkingGoose
HonkingGoose commented May 6, 2024
View reviewed changes
docs/usage/index.md Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose requested a review from viceice May 6, 2024 09:56
viceice
viceice reviewed May 6, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@rarkins rarkins requested a review from viceice May 8, 2024 04:47
@viceice viceice added this pull request to the merge queue May 10, 2024
Merged via the queue into renovatebot:main with commit 6b0d26c May 10, 2024
35 checks passed
@HonkingGoose HonkingGoose deleted the docs/move-homepage-file-from-docs-to-main-repo branch May 10, 2024 09:28
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.354.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HonkingGoose @renovate-release @viceice @rarkins