Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin to svelte #429

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Admin to svelte #429

wants to merge 11 commits into from

Conversation

jycouet
Copy link
Collaborator

@jycouet jycouet commented May 2, 2024

No description provided.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (a76ca40) to head (dfc91b9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files          78       78           
  Lines       19355    19355           
  Branches     3330     3330           
=======================================
  Hits        17852    17852           
  Misses       1503     1503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noam-honig noam-honig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to switch to that branch, went to /projects/remult-admin and did npm i - it have the following errors:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @xyflow/[email protected]
npm error Found: [email protected]
npm error node_modules/svelte
npm error   dev svelte@"5.0.0-next.120" from the root project
npm error   peer svelte@"^4.0.0 || ^5.0.0-next.0" from @sveltejs/[email protected]
npm error   node_modules/@sveltejs/vite-plugin-svelte
npm error     dev @sveltejs/vite-plugin-svelte@"^3.1.0" from the root project
npm error     peer @sveltejs/vite-plugin-svelte@"^3.0.0" from @sveltejs/[email protected]
npm error     node_modules/@sveltejs/vite-plugin-svelte-inspector
npm error       @sveltejs/vite-plugin-svelte-inspector@"^2.0.0" from @sveltejs/[email protected]
npm error   3 more (@sveltejs/vite-plugin-svelte-inspector, ...)
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^3.0.0 || ^4.0.0" from @xyflow/[email protected]
npm error node_modules/@xyflow/svelte
npm error   @xyflow/svelte@"0.0.41" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/svelte
npm error   peer svelte@"^3.0.0 || ^4.0.0" from @xyflow/[email protected]
npm error   node_modules/@xyflow/svelte
npm error     @xyflow/svelte@"0.0.41" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error C:\ProgramData\npm\npm-cache\_logs\2024-05-12T16_27_12_562Z-eresolve-report.txt

npm error A complete log of this run can be found in: C:\ProgramData\npm\npm-cache\_logs\2024-05-12T16_27_12_562Z-debug-0.log

@jycouet
Copy link
Collaborator Author

jycouet commented May 12, 2024

Tried to switch to that branch, went to /projects/remult-admin and did npm i - it have the following errors:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @xyflow/[email protected]
npm error Found: [email protected]
npm error node_modules/svelte
npm error   dev svelte@"5.0.0-next.120" from the root project
npm error   peer svelte@"^4.0.0 || ^5.0.0-next.0" from @sveltejs/[email protected]
npm error   node_modules/@sveltejs/vite-plugin-svelte
npm error     dev @sveltejs/vite-plugin-svelte@"^3.1.0" from the root project
npm error     peer @sveltejs/vite-plugin-svelte@"^3.0.0" from @sveltejs/[email protected]
npm error     node_modules/@sveltejs/vite-plugin-svelte-inspector
npm error       @sveltejs/vite-plugin-svelte-inspector@"^2.0.0" from @sveltejs/[email protected]
npm error   3 more (@sveltejs/vite-plugin-svelte-inspector, ...)
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^3.0.0 || ^4.0.0" from @xyflow/[email protected]
npm error node_modules/@xyflow/svelte
npm error   @xyflow/svelte@"0.0.41" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/svelte
npm error   peer svelte@"^3.0.0 || ^4.0.0" from @xyflow/[email protected]
npm error   node_modules/@xyflow/svelte
npm error     @xyflow/svelte@"0.0.41" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error C:\ProgramData\npm\npm-cache\_logs\2024-05-12T16_27_12_562Z-eresolve-report.txt

npm error A complete log of this run can be found in: C:\ProgramData\npm\npm-cache\_logs\2024-05-12T16_27_12_562Z-debug-0.log

Yes, svelte 5 is not "allowed" by a lot of libs.
Right now "npm i --force" make the thing going... But not ideal.
xyflow is working on a svelte 5 version, but not distributed yet.

We wanted to pin svelte 5 and see where we are at. We are at a good 4% 😅😭

CC @ermincelikovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants