Secure CI workflows against supply-chain attacks - #1393
Merged
Conversation
DougReeder
changed the title
raucao
changed the title
Member
|
@DougReeder Apparently, the actions were already locked down, and this PR made the runs fail on master (but for some reason not for the PR itself): https://github.com/remotestorage/remotestorage.js/actions/runs/28010199071 |
Contributor
Author
|
Good catch! I've updated the Actions Permissions for the repository, trimming the version from the allowed actions, so they won't be blocked by policy. If we want to be really secure, we could also pin our GitHub actions to a full-length commit SHA, and require SHAs for every action. |
Member
|
OK, thanks. It's definitely nicer to have these configs checked into the repo(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test: push branch to the master branch of your personal repo, in GitHub Actions tab, observe that test-and-lint and release-drafter complete successfully, and notify-website-repo only fails because "Parameter token or opts.auth is required"