Type, document, and refactor Sync, port tests to Mocha #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use _rs_init instead of custom prototype properties
Only log the message as debug log, without the stack trace refs #839
In order for devs not having to wait feature loading before managing access and caching settings, we need those classes to be instantiated onthe prototype already
|
FYI, I opened #1334 against this one, because it requires the new cachinglayer test suite. Can re-open against master later, if it doesn't get merged here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some small other improvements. However, this PR is mostly about properly typing and documenting sync, as well as making the functions more readable by using async/await in many places.
Also adds a new event called "sync-started", when a periodic/background sync has started (but not when outgoing changes are synced immediately).
refs #1251 (where I added sub-issues that are all easier to tackle with these changes)
closes #1173
closes #839
P.S.: I rebased the branch as much as possible before opening the PR. But there are too many conflicts when trying to consolidate the rest even more.