Skip to content

fix(react-router/router): propagate queryRoute errors that aren't Responses #13962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rossipedia
Copy link
Contributor

Attempt at fixing #13936

There are failing tests, not sure if that's indicative of an actual issue or if the tests need to be updated.

Copy link

changeset-bot bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: 093d782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 self-assigned this Jul 9, 2025
@MichaelDeBoey MichaelDeBoey changed the title propagate queryRoute errors that aren't Responses fix(react-router/router): propagate queryRoute errors that aren't Responses Jul 10, 2025
@MichaelDeBoey
Copy link
Member

@rossipedia These tests that are currently failing are very stable, so it's probably something in your code that made this happen

@rossipedia
Copy link
Contributor Author

@MichaelDeBoey Yeah not terribly unexpected. @brophdawg11 found some underlying issues that I think will make this PR unnecessary. We can probably close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants