Fix single fetch revalidation bug on reused routes #13105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d7b373 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Feb 25, 2025
| // Short circuit if we have no loaders to run, unless there's a custom dataStrategy | ||
| // since they may have different revalidation rules (i.e., single fetch) | ||
| if ( | ||
| !init.dataStrategy && |
There was a problem hiding this comment.
This causes issues with our "don't revalidate on action 4xx/5xx responses" logic since both scenarios result in a dataStrategy with all matches having shouldLoad: false. We may need to expose some more info to dataStrategy (or potentially just let dataStrategy handle all of the getMatchesToLoad logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.