fix: stop useNetworkConnectivity from causing hydration errors. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple fixes + SPA minimal mode
## @remix-pwa/cli 1.2.5 (2024-08-11) ### Bug Fixes * **cli:** added new `--dev` flag to the `upgrade` command - for updating to latest `dev` candidate d4f4414
## @remix-pwa/sw 3.0.9 (2024-08-11) ### Bug Fixes * **sw:** added `matchOptions` for adding querying options to cache operations c87e507
## @remix-pwa/worker-runtime 2.1.4 (2024-08-11) ### Bug Fixes * **worker-runtime:** added minimal support for runtimes in Remix SPA mode 6dd95e6
## @remix-pwa/sync 3.0.4 (2024-08-11) ### Dependencies * **@remix-pwa/sw:** upgraded to 3.0.9
|
@ShafSpecs are you able to have a look at this? |
|
Sorry, just doing so. For some reason, I don't get emails about actions in this organization 🥲. I need to fix that, my bad |
|
After the merge, you can check out your fix by installing the Sorry, I'm not with my PC this week and can't check it out fully. Once I'm able to, I would push to latest. And thx for the PR ❤️! |
|
I mean |
martin-wahlberg
deleted the
fix_hydration_errors_for_useNetworkConnectivity_hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We encountered hydration errors like:
Solution:
The issue was resolved by rewriting the hook to use
useSyncExternalStorage, ensuring consistency between server and client rendering.Request for Review:
The change has been tested and eliminates the hydration errors. Looking forward to your feedback and hoping for a quick merge.