Confidence intervals & nice(r) display #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VOvchinnikov
force-pushed
the
confidence-intervals
branch
12 times, most recently
from
a3d64fa to
8d57077
Compare
VOvchinnikov
changed the title
VOvchinnikov
force-pushed
the
confidence-intervals
branch
2 times, most recently
from
e391d04 to
8ed49a9
Compare
cedrics
reviewed
Sep 6, 2019
Added display_report method skeleton
Corrected `display` wrapper function
VOvchinnikov
force-pushed
the
confidence-intervals
branch
from
3a7ed5b to
408f6fb
Compare
VOvchinnikov
force-pushed
the
confidence-intervals
branch
from
03b03d7 to
6fc838f
Compare
alfrednfwong
approved these changes
Sep 9, 2019
lib/helpers.py
Outdated
| @@ -213,7 +213,10 @@ def _extract_revenue_events(df, revenue_event): | |||
|
|
|||
| @staticmethod | |||
| def _filter_by_user_ids(df, user_ids): | |||
| return df[df['user_id'].isin(user_ids)] | |||
| if 'user_id' in df.columns: | |||
There was a problem hiding this comment.
When do we have a df that doesnt have the 'user_id' column?
Or is it meant to also be used in other places?
| :param use_deduplication: Enable deduplication heuristic for AppsFlyer | ||
| of conversions (Default: false) | ||
| :param use_deduplication: Enable deduplication heuristic for AppsFlyer (Default: False) | ||
| :param confidence_level: Confidence level, required to calculate confidence intervals (Default: 0.95) |
There was a problem hiding this comment.
Gotta check with Eugen regarding the default value of the confidence level.
95% is in line with our old significance tests, which is nice. But using 90% or maybe even less will make the CIs smaller and cause fewer tricky cases for the AMs to explain.
|
it seems to be approved already, why is it in review column? I moved it |
cedrics
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.