Port make-frame-visible.
#1573
Open
Port make-frame-visible.
#1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good on first read. With CI being busted currently one of us needs to try it out locally. |
agraven
reviewed
Aug 7, 2020
| match self.current { | ||
| None => None, | ||
| Some(window) => { | ||
| self.current = window.next.as_valid_window(); |
There was a problem hiding this comment.
The window is not checked for validity in the original make_frame_visible_1, so you can just call .as_window()
| @@ -691,6 +695,36 @@ pub fn frame_face_alist(frame: LispFrameLiveOrSelected) -> LispObject { | |||
| frame_ref.face_alist | |||
| } | |||
|
|
|||
| /// Update the display_time slot of the buffers shown in WINDOW and all its descendants. | |||
| fn make_frame_visible_1(window: LispWindowRef) { | |||
There was a problem hiding this comment.
This function should preferably be a closure inside that make_frame_visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrect PR (#1526) and port
make-frame-visible. Fixed the failing tests and made it more rusty.