Refactor EmacsDouble and LispNumber handling. #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdrozd
reviewed
Feb 25, 2020
nickdrozd
reviewed
Feb 25, 2020
| @@ -260,25 +261,30 @@ pub enum ArithComparison { | |||
| GrtrOrEqual, | |||
| } | |||
|
|
|||
| pub fn arithcompare(obj1: LispObject, obj2: LispObject, comparison: ArithComparison) -> bool { | |||
| pub fn arithcompare( | |||
| obj1: LispNumberOrFloatOrMarker, | |||
There was a problem hiding this comment.
Maybe make these generic? impl Into<LispNumberOrFloatOrMarker, or whatever the syntax is. That would get rid of casting at call sites.
There was a problem hiding this comment.
Hmm, perhaps. Let me see how complex that is.
There was a problem hiding this comment.
Since the most common type is LispObject, I moved the more specific type into an internals function.
Co-Authored-By: Nick Drozd <[email protected]>
|
Thanks @nickdrozd for looking. |
|
Trying to trigger a Travis build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LispNumberOrMarker and refactors LispNumber to no
longer coerce markers.