[WIP] Port window-scroll-bars #1538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaleh
reviewed
Aug 14, 2019
| } else { | ||
| None | ||
| }; | ||
| list!( |
There was a problem hiding this comment.
Why did the original use Fcons instead of list6()?
There was a problem hiding this comment.
I believe that they only have up to list5:
Lines 3706 to 3711 in fb2e5d7
With list!, I think the rust version really shines
There was a problem hiding this comment.
Agreed. list! is so much nicer. I suspected that was the answer about list5, but I did not have the chance to check.
|
What is left to complete for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports
window-scroll-bars. I still need to add some ert tests, though.