Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Remacs logo in /assets subdirectory #1528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Created Remacs logo in /assets subdirectory #1528

wants to merge 1 commit into from

Conversation

stradicat
Copy link

Created a Remacs logo.
Forks & PRs are welcome.
source: https://github.com/dennismayr/remacs_logo

@sehnsucht13
Copy link
Contributor

I love it! I will wait for others to take a look as well and voice their opinions but I am all for the logo. Well done and thank you for taking the time to create this!!!

@stradicat
Copy link
Author

Thanks 😄

I'll work on a few lines I'm not completely satisfied with at the moment, there should be an update coming during the course of the weekend.

@shaleh
Copy link
Collaborator

shaleh commented Jul 24, 2019

Thank you for the time @DennisMayr

@agraven
Copy link
Collaborator

agraven commented Aug 29, 2019

Until you add the tweaks you like, we'd still like to use the logo as is if you don't mind :)

@stradicat
Copy link
Author

@agraven I don't mind at all 😄

This is one of those ambitious projects that works surprisingly well for an almost-beta stage (I've been using it regularly for a few hours a day for certain low-memory projects), and I think that this hard work has come to deserve some visual identity.

Copy link
Member

@harryfei harryfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. We can merge it if another reviewer approve.

@agraven
Copy link
Collaborator

agraven commented Nov 29, 2019

My main concern is putting the file in the appropriate location, which is slightly difficult when the branch the PR was made from has been deleted. Also, I can see the logo uses inkscape specific tags, i'd like to get those converted to more standard ones (it's as simple as opening the file in inkscape and saving it as "Basic SVG" or whatever it is they call it), but I don't see an immediately obvious way of making those changes while preserving dennismayr's status as author.

@stradicat
Copy link
Author

I could run svgo on this Inkscape-generated SVG to remove those tags (and optimize the file size while at it).

I'll give it a few tries over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants