port command-remapping #1477
Open
port command-remapping #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agraven
requested changes
May 18, 2019
rust_src/src/keymap.rs
Outdated
| /// remapping in all currently active keymaps. | ||
| #[lisp_fn(min = "1")] | ||
| pub fn command_remapping( | ||
| command: Option<LispSymbolRef>, |
There was a problem hiding this comment.
It's quite strange that the original function behaves this way, but the original function accepts any type and returns Qnil if it's not a symbol. I recommend changing command to a LispObject and then doing let c = match command.as_symbol() ...
rust_src/src/keymap.rs
Outdated
| key_binding(command_remapping_vector, false, true, position) | ||
| } else { | ||
| lookup_key( | ||
| LispObject::cons(Qkeymap, keymaps), |
There was a problem hiding this comment.
Suggested change
| LispObject::cons(Qkeymap, keymaps), | |
| (Qkeymap, keymaps).into(), |
brotzeit
force-pushed
the
command-remapping
branch
from
4bf8024
to
3a79028
Compare
agraven
reviewed
Jun 11, 2019
test/rust_src/src/keymap-tests.el
Outdated
|
|
||
| (define-key my-mode-map [remap kill-line] 'my-kill-line) | ||
|
|
||
|
|
There was a problem hiding this comment.
The whitespace looks very strange in the changes in this file, and the body of test-command-remapping is empty. Is this part unfinished?
There was a problem hiding this comment.
Oops, I pushed the wrong branch.
|
@brotzeit wanna update this one? |
brotzeit
force-pushed
the
command-remapping
branch
from
3a79028
to
4bf8024
Compare
brotzeit
force-pushed
the
command-remapping
branch
from
4bf8024
to
31b60da
Compare
brotzeit
force-pushed
the
command-remapping
branch
from
31b60da
to
ed22c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.