Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hfs-lang-ru.json #925

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update hfs-lang-ru.json #925

wants to merge 5 commits into from

Conversation

albamef
Copy link
Contributor

@albamef albamef commented Feb 28, 2025

Translation improvements

Translation improvements
@SanokKule
Copy link
Contributor

Leave "Comment": "Комментарий",as is, it's used for search and will not look right.
Screenshot_2025-02-28-13-06-45-180_com chrome beta

Or rejetto should add another string for this dialog.

@SanokKule
Copy link
Contributor

Also why change "enter_comment": "Комментарий для {name}", ?

@albamef
Copy link
Contributor Author

albamef commented Feb 28, 2025

Also why change "enter_comment": "Комментарий для {name}", ?

You right about this and about "another string for this dialog.". But "Комментировать" looks better in file menu.
Снимок

@rejetto
Copy link
Owner

rejetto commented Feb 28, 2025

thanks for your contribution!

@SanokKule i trust your judgement, should i merge these changes? Are there some that you would keep out?

@SanokKule
Copy link
Contributor

Can you add "Search in comments" field?

@SanokKule
Copy link
Contributor

SanokKule commented Feb 28, 2025

Keep "Comment": "Комментарий" as is, and if you add "Search in comments" it should say "Поиск по комментариям"

@rejetto
Copy link
Owner

rejetto commented Feb 28, 2025

what if i instead change from this

image

to this
image

i think it's better, because it's more generic; the day i add "size", we don't need to have a new text to translate.

@SanokKule
Copy link
Contributor

SanokKule commented Feb 28, 2025

I like it, but now that i think about it, is the Comment button in File menu supposed to be a noun or a verb?
Comment in Russian is noun комментарий and verb комментировать. Should be different in both places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants