Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conditional error when disabling, treating warnings as errors #277

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

DaveSkender
Copy link
Contributor

@DaveSkender DaveSkender commented Dec 14, 2023

Fixes #266, partially addresses #235

As someone who a) wants to disable mutation of source code on my build server, because it's a volatile thing that I don't want, and also b) wants to be conservative and treat my [unintentional] warnings as errors, I cannot do that because this always fails:

dotnet build --property:RtDisable=true --property:TreatWarningsAsErrors=true

The recommendation here is to simply decouple these properties and only Message when something is disabled as an intentional act.

Also consider:

@pavel-b-novikov pavel-b-novikov merged commit 59d68a6 into reinforced:master Dec 14, 2023
@DaveSkender DaveSkender deleted the decouple-disable-error branch December 14, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<RtDisable> and <TreatWarningsAsError> not working
2 participants