remove conditional error when disabling, treating warnings as errors #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266, partially addresses #235
As someone who a) wants to disable mutation of source code on my build server, because it's a volatile thing that I don't want, and also b) wants to be conservative and treat my [unintentional] warnings as errors, I cannot do that because this always fails:
The recommendation here is to simply decouple these properties and only
Message
when something is disabled as an intentional act.Also consider:
Warning
type with a unique error code for suppression, see RT and TreatWarningsAsErrors #235. I've opted forMessage
type in my recommendation.