Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing linkify-code #98

Open
wants to merge 1 commit into
base: default-a
Choose a base branch
from
Open

Testing linkify-code #98

wants to merge 1 commit into from

Conversation

fregante
Copy link
Member

@fregante fregante commented Oct 30, 2024

Code blocks

Native links:

Inline code blocks with https://example.com or http://example.org

JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github
No syntax:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github

Code blocks in table

Native links:

Inline code blocks with https://example.com or http://example.org

JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github
No syntax:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github

Inline code

sandbox/README.md

Lines 17 to 24 in 7becc26

1. I open an issue named `Testing in-title #1 issue references`
3. I use its URL in a PR, like:
```md
I created this feature that works on titles.
# Test URLs
https://github.com/refined-github/sandbox/issues/345

Comment on lines +1 to +7
https://github.com/refined-github/refined-github/pull/7985

```js
JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github
```
Copy link
Member Author

@fregante fregante Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment

Code blocks

Native links:

Inline code blocks with https://example.com or http://example.org

JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github
No syntax:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github

Code blocks in table

Native links:

Inline code blocks with https://example.com or http://example.org

JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github
No syntax:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github

Inline code

sandbox/README.md

Lines 17 to 24 in 7becc26

1. I open an issue named `Testing in-title #1 issue references`
3. I use its URL in a PR, like:
```md
I created this feature that works on titles.
# Test URLs
https://github.com/refined-github/sandbox/issues/345

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://github.com/refined-github/refined-github/pull/7985
```js
JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github
```
https://github.com/refined-github/refined-github/pull/7985
```js
JS:
issues: // #12, GH-34, fregante#1 and facebook/react#5678
url: // https://github.com/?q=refined-github

@kovsu kovsu marked this pull request as draft December 19, 2024 02:57
@kovsu kovsu marked this pull request as ready for review December 19, 2024 02:57
@kovsu kovsu marked this pull request as draft December 19, 2024 02:58
@kovsu kovsu marked this pull request as ready for review December 19, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant