Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locked-issue - Remove after unlocking issue #7075

Merged
merged 3 commits into from
Nov 23, 2023
Merged

locked-issue - Remove after unlocking issue #7075

merged 3 commits into from
Nov 23, 2023

Conversation

Katsute
Copy link
Contributor

@Katsute Katsute commented Nov 17, 2023

Resolves a bug that was introduced in ce78ed0 ; commit inadvertently put d-flex and rgh-locked-issue in the same element causing this css issue.

The css used to re-hide the lock state on update was not active because d-flex was taking precedence.

flex

Test URLs

Test requires looking at an issue as it is being unlocked

refined-github/sandbox#74

Screenshot

display: none now takes precedence

none

@Katsute Katsute changed the title locked-issue Fix lock showing on newly unlocked issues locked-issue - Fix lock showing on newly unlocked issues Nov 17, 2023
@fregante
Copy link
Member

Are any of those classes needed? It doesn't look like it, we should drop them:

Screenshot 5

@fregante
Copy link
Member

Same goes for the sticky version:

Screenshot

@fregante fregante added the bug label Nov 18, 2023
@Katsute
Copy link
Contributor Author

Katsute commented Nov 18, 2023

Both were using the identical css as the open/close badges, there might be some redundancies but I'm not sure which ones.

For reference: #7051 (comment)

@fregante
Copy link
Member

I'm not sure which ones

All the necessary style is in State. See the classes I left in my screenshots to find which to remove (basically everything related to flexbox)

@fregante
Copy link
Member

flex-shrink-0 can be left there, all the siblings have it

@fregante fregante changed the title locked-issue - Fix lock showing on newly unlocked issues locked-issue - Remove after unlocking issue Nov 23, 2023
@fregante fregante merged commit a250341 into refined-github:main Nov 23, 2023
9 checks passed
@fregante
Copy link
Member

😌
🙏

@Katsute Katsute deleted the fix-issue-lock-update branch November 23, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants