-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locked-issue
- Remove after unlocking issue
#7075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katsute
changed the title
Nov 17, 2023
locked-issue
Fix lock showing on newly unlocked issueslocked-issue
- Fix lock showing on newly unlocked issues
fregante
approved these changes
Nov 18, 2023
Both were using the identical css as the open/close badges, there might be some redundancies but I'm not sure which ones. For reference: #7051 (comment) |
All the necessary style is in State. See the classes I left in my screenshots to find which to remove (basically everything related to flexbox) |
|
Katsute
commented
Nov 18, 2023
fregante
changed the title
Nov 23, 2023
locked-issue
- Fix lock showing on newly unlocked issueslocked-issue
- Remove after unlocking issue
😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a bug that was introduced in ce78ed0 ; commit inadvertently put
d-flex
andrgh-locked-issue
in the same element causing this css issue.The css used to re-hide the lock state on update was not active because
d-flex
was taking precedence.Test URLs
Test requires looking at an issue as it is being unlocked
refined-github/sandbox#74
Screenshot
display: none
now takes precedence