Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new PR view in isClosedIssue; tighten related checks #201

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Nov 6, 2024

No description provided.

@kovsu kovsu marked this pull request as draft November 6, 2024 01:24
@kovsu kovsu changed the title Refactor PR state selectors and add checks for PR and issue types Add checks for PR and issue types and Support new view in isClosedIssue Nov 6, 2024
@kovsu kovsu marked this pull request as ready for review November 6, 2024 01:27
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
@fregante fregante changed the title Add checks for PR and issue types and Support new view in isClosedIssue Support new PR view in isClosedIssue; tighten related checks Nov 6, 2024
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you merge this PR and release a new version. You can do so from the Actions tab, Releases, then type patch in the version field and wait for the release to appear ☺️

@kovsu kovsu merged commit 7ef1350 into refined-github:main Nov 6, 2024
15 checks passed
@kovsu kovsu deleted the fix-1 branch November 6, 2024 03:29
@kovsu
Copy link
Member Author

kovsu commented Nov 6, 2024

Oh, I should clean the description input when merging.

@fregante
Copy link
Member

fregante commented Nov 6, 2024

clear-pr-merge-commit-message didn't work?

@kovsu
Copy link
Member Author

kovsu commented Nov 6, 2024

It seems doesn't work. Let me check it.

image

@fregante
Copy link
Member

fregante commented Nov 6, 2024

It works but it's limited: refined-github/refined-github#6611 (comment)

Ignore for now

'.State',
'[class^="StateLabel"]',
'[data-testid="header-state"]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@fregante fregante Nov 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants