Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(account): add migration to AddUserMember interactor [FLOW-BE-34] #78

Conversation

akiyatomohiro
Copy link
Contributor

@akiyatomohiro akiyatomohiro commented Mar 5, 2025

…(#74)"

This reverts commit 6f054a7.

Summary by CodeRabbit

  • Refactor
    • Removed legacy role and permission management components and their supporting builders and utilities.
    • Simplified workspace member handling by eliminating outdated role validation logic.
  • Chore
    • Cleaned up redundant fields and interfaces across internal data repositories and storage layers.
  • Tests
    • Removed obsolete test cases and improved formatting consistency for enhanced readability.

Copy link

coderabbitai bot commented Mar 5, 2025

Walkthrough

The changes remove a comprehensive set of role and permission management components across the codebase. In the domain layer, types, methods, builders, and aliases for Role and Permittable are deleted. In the infrastructure layer, in-memory and MongoDB implementations related to these functionalities have been removed. The use case layer has been simplified by eliminating functions and tests for role validation and migration. Overall, the diff reflects a refactoring effort to deprecate role and permission handling in anticipation of a new implementation or migration.

Changes

File(s) Change Summary
account/accountdomain/id.go Removed Role and Permittable types, their methods (Type()), aliases (e.g., RoleID, PermittableID), and utility variables (e.g., NewRoleID, MustPermittableID).
account/accountdomain/permittable/* Removed builder (builder.go), ID (id.go), list (list.go), and primary Permittable struct along with its methods (ID(), UserID(), RoleIDs(), EditRoleIDs()).
account/accountdomain/role/* Removed Role builder (builder.go), ID handling (id.go), list (list.go), and Role struct with methods (ID(), Name(), Rename()) along with related error variables.
account/accountinfrastructure/accountmemory/* Removed initialization of Role and Permittable fields from Container and deleted in-memory implementations for Role and Permittable management.
account/accountinfrastructure/accountmongo/* Removed Mongo document conversion logic and MongoDB interfacing implementations for Role and Permittable (files in both mongodoc and main directories).
account/accountusecase/accountinteractor/* and account/accountusecase/accountrepo/* Removed role check functions (e.g., getMaintainerRole, ensureUserHasMaintainerRole, hasRole), obsolete migration tests, and dropped Role/Permittable interfaces and fields from repository containers.

Sequence Diagram(s)

Loading
sequenceDiagram
    participant Client
    participant Workspace
    participant AccountRepo
    Client->>Workspace: AddUserMember(userID)
    Note right of Workspace: Role checks removed
    Workspace->>AccountRepo: Add user member
    AccountRepo-->>Workspace: Confirmation
    Workspace-->>Client: Success response

Suggested reviewers

  • rot1024
  • pyshx

Poem

In a barren code field once overgrown,
I, a small rabbit, now happily roam.
Roles and permits have hopped away,
Leaving a cleaner, brighter day.
With each line pruned, our paths align,
Hop by hop, the code does shine.
Celebrating change with a joyful sign! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c870998 and 6d7771f.

📒 Files selected for processing (21)
  • account/accountdomain/id.go (0 hunks)
  • account/accountdomain/permittable/builder.go (0 hunks)
  • account/accountdomain/permittable/id.go (0 hunks)
  • account/accountdomain/permittable/list.go (0 hunks)
  • account/accountdomain/permittable/permittable.go (0 hunks)
  • account/accountdomain/role/builder.go (0 hunks)
  • account/accountdomain/role/id.go (0 hunks)
  • account/accountdomain/role/list.go (0 hunks)
  • account/accountdomain/role/role.go (0 hunks)
  • account/accountinfrastructure/accountmemory/container.go (0 hunks)
  • account/accountinfrastructure/accountmemory/permittable.go (0 hunks)
  • account/accountinfrastructure/accountmemory/role.go (0 hunks)
  • account/accountinfrastructure/accountmongo/mongodoc/permittable.go (0 hunks)
  • account/accountinfrastructure/accountmongo/mongodoc/role.go (0 hunks)
  • account/accountinfrastructure/accountmongo/permittable.go (0 hunks)
  • account/accountinfrastructure/accountmongo/role.go (0 hunks)
  • account/accountusecase/accountinteractor/workspace.go (0 hunks)
  • account/accountusecase/accountinteractor/workspace_test.go (8 hunks)
  • account/accountusecase/accountrepo/container.go (0 hunks)
  • account/accountusecase/accountrepo/permittable.go (0 hunks)
  • account/accountusecase/accountrepo/role.go (0 hunks)
💤 Files with no reviewable changes (20)
  • account/accountusecase/accountrepo/container.go
  • account/accountusecase/accountrepo/permittable.go
  • account/accountinfrastructure/accountmemory/container.go
  • account/accountdomain/role/role.go
  • account/accountinfrastructure/accountmongo/mongodoc/role.go
  • account/accountusecase/accountrepo/role.go
  • account/accountdomain/permittable/permittable.go
  • account/accountdomain/role/builder.go
  • account/accountdomain/permittable/builder.go
  • account/accountusecase/accountinteractor/workspace.go
  • account/accountdomain/permittable/list.go
  • account/accountinfrastructure/accountmongo/mongodoc/permittable.go
  • account/accountdomain/role/id.go
  • account/accountinfrastructure/accountmongo/permittable.go
  • account/accountinfrastructure/accountmongo/role.go
  • account/accountinfrastructure/accountmemory/permittable.go
  • account/accountdomain/permittable/id.go
  • account/accountdomain/role/list.go
  • account/accountinfrastructure/accountmemory/role.go
  • account/accountdomain/id.go
✅ Files skipped from review due to trivial changes (1)
  • account/accountusecase/accountinteractor/workspace_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@akiyatomohiro akiyatomohiro self-assigned this Mar 5, 2025
@akiyatomohiro akiyatomohiro marked this pull request as ready for review March 5, 2025 16:18
@akiyatomohiro akiyatomohiro requested a review from rot1024 as a code owner March 5, 2025 16:18
@akiyatomohiro akiyatomohiro requested review from pyshx and removed request for pyshx March 5, 2025 16:21
@akiyatomohiro akiyatomohiro marked this pull request as draft March 5, 2025 16:26
@pyshx pyshx changed the title Revert "feat: add migration to AddUserMember interactor [FLOW-BE-34] … chore(account): add migration to AddUserMember interactor [FLOW-BE-34] Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant