Migrate type tests to Vitest #697
Open
+3,235
−4,124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reselect-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
aryaemami59
force-pushed
the
migrate-typetests-to-vitest
branch
2 times, most recently
from
ef6c07f
to
b44c7e5
Compare
aryaemami59
force-pushed
the
migrate-typetests-to-vitest
branch
2 times, most recently
from
492bf78
to
f5ffebb
Compare
aryaemami59
force-pushed
the
migrate-typetests-to-vitest
branch
3 times, most recently
from
78c3325
to
d7a07ff
Compare
aryaemami59
force-pushed
the
migrate-typetests-to-vitest
branch
from
282544d
to
d7a07ff
Compare
aryaemami59
force-pushed
the
migrate-typetests-to-vitest
branch
17 times, most recently
from
0c7a1ed
to
d6435a4
Compare
- There were multiple `store.dispatch` calls that were not needed. These were removed to clean up the test file and speed up execution of tests.
- This was done mainly to speed up executions of unit tests.
- Looks like some of the code in `computationComparisons.spec.tsx` wasn't properly updated after we switched the default memoization function from `lruMemoize` to `weakMapMemoize`. These have been updated to their correct implementations. - Correct residual naming inconsistencies from the previous `defaultMemoize` to `lruMemoize` renaming. All references to `default` have been updated to `lru`.
aryaemami59
force-pushed
the
migrate-typetests-to-vitest
branch
from
d55f7cb
to
4b41040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
typetest.tsfile extensions totest-d.tsto be compatible with Vitest.expectType()to eitherassertType()orexpectTypeOf().toMatchTypeOf().expectExactTypetoexpectTypeOf().toEqualTypeOf().testordescribeblocks.