Update part-5-async-logic.md #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some typos and highlighting
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
i don't think the status change makes sense - i would either consider "succeed" and "fail" or "fulfill" and "reject", but "succeed" and "reject" seems odd. |
timdorr
reviewed
Oct 29, 2024
Changed failed status in PostsState to failed
matthiasnagel
commented
Oct 31, 2024
| @@ -326,7 +326,7 @@ import { createSlice, nanoid } from '@reduxjs/toolkit' | |||
| // highlight-start | |||
| interface PostsState { | |||
| posts: Post[] | |||
| status: 'idle' | 'pending' | 'succeeded' | 'rejected' | |||
| status: 'idle' | 'pending' | 'succeeded' | 'failed' | |||
There was a problem hiding this comment.
The idea was to follow the AsyncThunk types pending, fulfilled, rejected. Nevertheless switching back to failed we have to correct it here in the docs otherwise the reader is confused.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some typos and highlighting
Thanks for the PR!
To better assist you, please select the type of PR you want to create.
Click the "Preview" tab above, and click on the link for the PR type: