Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to MSW 2.0 | rest import discontinued and replaced by http instead #4607

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Benluv
Copy link
Contributor

@Benluv Benluv commented Oct 23, 2023

📝 Documentation Fix

…tp instead

- In msw docs they seem to be using http and HttpResponse for requests https://mswjs.io/docs/api/setup-server/
- Delay is performed with await so the function is now async https://mswjs.io/docs/api/delay/
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f65bb78:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@EskiMojo14
Copy link
Contributor

The build is failing because this is a MSW 2.0 (released this morning) specific API - can you update the dependency in both /docs and /website?

@EskiMojo14 EskiMojo14 changed the title Update WritingTests.mdx | rest import discontinued and replaced by http instead Update docs to MSW 2.0 | rest import discontinued and replaced by http instead Oct 23, 2023
… (due to msw expecting 4.7.0 and 5.2.0 inclusive) in /website
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit f65bb78
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/653693684706af0008e06f22
😎 Deploy Preview https://deploy-preview-4607--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@timdorr
Copy link
Member

timdorr commented Oct 23, 2023

Thanks!

@timdorr timdorr merged commit 8e58a32 into reduxjs:master Oct 23, 2023
11 checks passed
@Benluv
Copy link
Contributor Author

Benluv commented Oct 23, 2023

Thank you as well, was a pleasure to lend a hand! Keep the good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants