Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default Node version in CI #4600

Closed
wants to merge 2 commits into from
Closed

Conversation

nickserv
Copy link
Contributor

@nickserv nickserv commented Sep 13, 2023

Deprecated Node versions are used in CI, potentially causing security and reliability issues. Instead, it's better to use GitHub's default Node version, which also doesn't require additional downloads or installations.

Deprecated Node versions are used in CI, potentially causing security and reliability issues. Instead, it's better to use GitHub's default Node version, which also doesn't require additional downloads or installations.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5daad8a:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@nickserv
Copy link
Contributor Author

The size action is warning because of preactjs/compressed-size-action#93 but it seems like it's safe to ignore as it already runs on Node 16:

The following actions uses node12 which is deprecated and will be forced to run on node16: preactjs/compressed-size-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@nickserv
Copy link
Contributor Author

Blocked by reduxjs/redux-toolkit#3715

@nickserv nickserv marked this pull request as draft September 13, 2023 03:20
@timdorr
Copy link
Member

timdorr commented Mar 10, 2024

This should be superseded by #4680

@timdorr timdorr closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants