Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color property to 'code' css declaration #4589

Conversation

BarokDG
Copy link
Contributor

@BarokDG BarokDG commented Aug 14, 2023


name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page

Checklist

What docs page needs to be fixed?

  • The inline code blocks used inside DetailedExplanation.tsx

What is the problem?

It's difficult to see the text in inline code blocks inside the DetailedExplanation component in dark mode. The css doesn't match the styles used for inline code blocks on the rest of the documentation.

What changes does this PR make to fix the problem?

I added a css 'color' property to the code declaration inside website\src\css\custom.css. The value is consistent with what's used outside the DetailedExplanation component.

Before

image

After

image

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42508c0:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit 42508c0
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/64d9edb52064e3000868a6c8
😎 Deploy Preview https://deploy-preview-4589--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markerikson markerikson merged commit 1c087cb into reduxjs:master Aug 14, 2023
6 checks passed
@markerikson
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants