Optimized the isPlainObject.ts #4583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this version, unnecessary iteration through the prototype chain has been eliminated by directly comparing the object's prototype with the base Object.prototype. The code is more concise, easier to read, and performs the same functionality
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 004e006:
|
|
Thanks for the PR! Unfortunately as you can see, the tests have failed meaning this change introduces a regression. If you can ensure the same functionality is possible with your change, then we can consider it :) |
Code optimization
Update isPlainObject.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version, unnecessary iteration through the prototype chain has been eliminated by directly comparing the object's prototype with the base Object.prototype. The code is more concise, easier to read, and performs the same functionality
Thanks for the PR!
To better assist you, please select the type of PR you want to create.
Click the "Preview" tab above, and click on the link for the PR type: