[v24.2.x] rpk container: tag and error improvements #25676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to release a new v3 console version that contains configuration changes. Ideally, the console tag should be passed at build time, but in the meantime, we will fix the tag to v2.8.5 to avoid automatically upgrading to v3 in rpk without the config changes. (cherry picked from commit 53a2ac8)
For stranded console containers. This could happen if the user manually stops and remove the Redpanda broker containers and leave the Console container up. This provides a better error message than just an empty log from Docker. (cherry picked from commit 7095001)
Instead of printing the logs of the first container by default. (cherry picked from commit 057da1d)
A typical example would be: user tries to start n=3 cluster. node n-1 fails console didn't stat Then, the user tries to start again, rpk will trigger the restart path if the user didn't purge the previous cluster. This prevents a panic as at this point the console container state will be nil (cherry picked from commit dcd2220)
vbotbuildovich
requested review from
gene-redpanda,
r-vasquez and
twmb
as code owners
r-vasquez
approved these changes
Apr 1, 2025
Collaborator
Author
CI test resultstest results on build#64044
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #25645