Skip to content

[v25.1.x] iceberg: fix compatibility for schemas with map type #25669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #25668

Some mild refactoring to make this test more flexible for adding future
test cases.

(cherry picked from commit a064515)
…_type`

Keys are required per the iceberg spec: https://iceberg.apache.org/spec/#nested-types.

Before this change, `redpanda` would fail to properly use schemas for tables
created with a `map` in the schema, and would incorrectly try to evolve
the schema due to the detected difference in `field_required`.

After this fix, schemas with nested `map` types work as expected.

(cherry picked from commit 72a4c17)
For use with `DatalakeE2ETests.test_avro_schema`.

(cherry picked from commit 8d0f830)
@vbotbuildovich vbotbuildovich added this to the v25.1.x-next milestone Apr 1, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 1, 2025
@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#64019
test_id test_kind job_url test_status passed
rptest.tests.cluster_config_test.ClusterConfigTest.test_valid_settings ducktape https://buildkite.com/redpanda/redpanda/builds/64019#0195f0c9-5ca1-410d-b4b6-58c8c2d2fda2 FLAKY 1/2
rptest.transactions.consumer_offsets_test.VerifyConsumerOffsetsThruUpgrades.test_consumer_group_offsets.versions_to_upgrade=1 ducktape https://buildkite.com/redpanda/redpanda/builds/64019#0195f0c9-5ca1-4fc2-8755-383813b0a604 FLAKY 1/2

@WillemKauf WillemKauf merged commit 0e1d236 into redpanda-data:v25.1.x Apr 1, 2025
18 checks passed
@piyushredpanda piyushredpanda modified the milestones: v25.1.x-next, v25.1.2 Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants