[CORE-9523] Consumer Group Lag: Set empty shard label #25383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IoannisRP
reviewed
Mar 14, 2025
CI test resultstest results on build#63138
test results on build#63218
test results on build#63365
|
BenPope
force-pushed
the
core-9523/consumer_group_lag_aggregate_shard
branch
from
8b6e49e to
362e600
Compare
IoannisRP
previously approved these changes
Mar 17, 2025
4 tasks
|
This is a bit of an anti pattern because of the issue described here: #23339 I don't think cardinality itself is an issue anymore as per previous discussions. If you really want to avoid the shard label changing I think best would be to explicitly add the shard label with a static value ("0" or "") as that will prevent seastar from adding it automatically (with the varying shard). |
As currently implemented, the metrics contain the shard label, which can add to cardinality over time as the group coordinator can change shard. Reduce cardinality by explicitly setting shard label empty, to prevent seastar from adding it. Signed-off-by: Ben Pope <[email protected]>
A group which has transitioned to dead does not need metrics; ensure metrics are only emmitted when state is not dead by checking the state in setup_metrics(), and set_state where all transitions pass through. This avoids making requests for partition offsets when not necessary. Signed-off-by: Ben Pope <[email protected]>
BenPope
force-pushed
the
core-9523/consumer_group_lag_aggregate_shard
branch
from
362e600 to
d64ca1b
Compare
BenPope
changed the title
|
Changes in force-push
|
|
/backport v25.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently implemented, the metrics contain the shard label, which can add to cardinality over time as the group coordinator can change.
Override the shard label to prevent seastar setting it, to prevent cardinality increase if the group coordinator moves shard.
Backports Required
Release Notes