Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: upgrade to clang-19 #25368

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

bazel: upgrade to clang-19 #25368

wants to merge 7 commits into from

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Mar 13, 2025 •
edited
Loading

Upgrade bazel to clang-19

Highlights in libc++: https://libcxx.llvm.org/ReleaseNotes/19.html

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

rockwotj added 5 commits March 14, 2025 14:18
@rockwotj
bazel: upgrade to clang-19
ac4856e
@rockwotj
bazel/toolchain: disable libxml2
2ea9d0f
@rockwotj
bazel/toolchain: rebuild clang-19
5926ad6 
This time with libxml2 disabled so CI doesn't choke.
@rockwotj
iceberg: fix clang-19 error
f41e127 
```
explicit specialization cannot have a storage class
```
@rockwotj
ct: include what you use
a225869
rockwotj added 2 commits March 16, 2025 02:34
@rockwotj
bazel/3p: parallelize openssl fips build same as non-fips
b499f47
@rockwotj
ct: fix compilation with libc++ 19
43bdd79 
From libc++19 release notes:

> libc++ no longer supports std::allocator<const T> and containers of const-qualified element type, such as std::vector<const T> and std::list<const T>. This used to be supported as an undocumented extension. If you were using std::vector<const T>, replace it with std::vector<T> instead. The _LIBCPP_ENABLE_REMOVED_ALLOCATOR_CONST macro can be defined to temporarily re-enable this extension. to temporarily re-enable this extension to make it easier to update user code This macro will be honored for one released and ignored starting in LLVM 20. To assist with the clean-up process, consider running your code through Clang Tidy, with std-allocator-const enabled.
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#63204
test_id test_kind job_url test_status passed
kafka_server_rpfixture.kafka_server_rpfixture unit https://buildkite.com/redpanda/redpanda/builds/63204#01959cd7-8645-4da4-93c6-995cb04b2822 FLAKY 1/2
rptest.tests.crash_loop_checks_test.CrashLoopChecksTest.test_crash_report_with_signal.signo=Signals.SIGILL.signal_shard=1 ducktape https://buildkite.com/redpanda/redpanda/builds/63204#01959d18-bde7-47ac-8610-2f5db61a5747 FLAKY 1/2
rptest.tests.datalake.datalake_upgrade_test.DatalakeUpgradeTest.test_upload_through_upgrade.cloud_storage_type=CloudStorageType.S3.query_engine=QueryEngineType.SPARK ducktape https://buildkite.com/redpanda/redpanda/builds/63204#01959d1c-7aa9-4b30-9e38-41d639447f44 FLAKY 1/4
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/63204#01959d1c-7aa8-4644-acee-7cad327746fc FLAKY 1/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rockwotj @vbotbuildovich