Better ACL error message in the overview tab #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jvorcak
commented
Mar 13, 2025
jvorcak
commented
jvorcak
changed the title
jvorcak
force-pushed
the
fix/bettter-acl-error-message-in-overview
branch
from
645d1a8 to
8993d9b
Compare
weeco
reviewed
Mar 14, 2025
Comment on lines
+324
to
+326
| const aclCount = overview.kafkaAuthorizerInfo | ||
| ? overview.kafkaAuthorizerInfo.aclCount | ||
| : (overview.kafkaAuthorizerError?.message ?? 'Authorizer not configured'); |
Contributor
There was a problem hiding this comment.
We should work with the error codes we return in connectrpc responses. Possibly we should tackle this as an initiative but these error codes have been introduced so that we have more control over how we can present errors in the UI.
Collaborator
Author
There was a problem hiding this comment.
I'm working on a new way of data fetching right now, so I'll take this into consideration.
Contributor
There was a problem hiding this comment.
@jvorcak you can check how we render toasts and how queries/mutations in custom hooks handle errors, you can also experiment with ConnectError.from()
weeco
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.