sync FT.AGGREGATE #815
Merged
sync FT.AGGREGATE #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Mar 29, 2025
internal/cmds/gen_search.go
Outdated
| @@ -17,6 +17,58 @@ func (c FtAggregate) Index(index string) FtAggregateIndex { | |||
| return (FtAggregateIndex)(c) | |||
| } | |||
|
|
|||
| type FtAggregateScorer Incomplete | |||
There was a problem hiding this comment.
The internal/cmds/gen_search.go file is auto-generated from hack/cmds/commands_search.json by running go generate. Did you make changes to hack/cmds/commands_search.json?
There was a problem hiding this comment.
I've now updated hack/cmds/commands_search.json and regenerated the code.
rueian
reviewed
Mar 29, 2025
rueidiscompat/command.go
Outdated
| @@ -3466,6 +3466,8 @@ type FTAggregateOptions struct { | |||
| Verbatim bool | |||
| LoadAll bool | |||
| WithCursor bool | |||
| Scorer string | |||
There was a problem hiding this comment.
Almost looks good to me, but this string field should be moved up to the next position after Filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #770