Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defragment support for HFE #13229
Add defragment support for HFE #13229
Changes from 33 commits
5ee153e
53dbff1
3162c25
9117b42
4986870
f7bf686
99b3bad
09562c4
761b3a4
5a86b46
6942c4a
fdbc69e
af9eadc
871ec6f
b19f6f5
5e8dfd1
2f988f0
f8bbf7f
acfc293
4a9f8f6
d701bf8
dcc5da0
35ec1a3
1f62c55
c0ec94c
c270ca4
5fe4b02
1318272
6177070
06d13a3
cd7396c
3b5b33b
eada402
c952c1e
08c4276
b8f81a0
78cebfc
ea61eb4
2d40d61
b90ab61
66c8785
f2124a5
4f64806
2ea37aa
f9c0106
293b127
765ebc4
b59dbb7
7e8cd04
aa096d1
2296d05
920d784
d0b523c
6c6c6a4
7712b00
d20743e
ac1130f
f0c74fa
07dad91
36bd618
2c0b560
e8ea643
d1ce106
5775ba0
f0ec7e3
9e323bb
01563e6
9a2fb77
af548c8
661fc72
b187702
e6b8b6b
1662f40
1452444
496e242
b18cb26
2d86fc8
6fdbfb3
5bf9ddb
0936517
1bea6c9
b619ea5
5023c03
ebbb291
8db938b
8363b2c
79cdbb0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add assert and verify all the calls to this function that the ExpireMeta of the item is not trash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hfieldGetExpireTime() has ensured that the trash is not 1.
the caller is responsible for ensuring the item has TTL via
hfieldGetExpireTime()
, otherwise, all the calls to this function will be dangerous.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added comment (include note) for this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after struggling, i decide to add the assertion.