Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize invalid TCP_KEEPINTVL and simplify TCP_KEEPALIVE_ABORT_THRESHOLD on Solaris #13142

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

panjf2000
Copy link
Contributor

@panjf2000 panjf2000 commented Mar 14, 2024

Two things:

  1. Avoid invalid value being set to TCP_KEEPINTVL and raising an error
  2. Simplify setting TCP_KEEPALIVE_ABORT_THRESHOLD by eliminating the needless calculations

The time between each consequent probes is set by TCP_KEEPINTVL in seconds. The minimum value is ten seconds. The maximum is ten days, while the default is two hours.

From TCP on Solaris

src/anet.c Outdated Show resolved Hide resolved
Co-authored-by: Viktor Söderqvist <[email protected]>
@panjf2000
Copy link
Contributor Author

Ping @oranagra

src/anet.c Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Mar 24, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants