feat(cluster): refactor sharded pub/sub v4 #2042
Conversation
|
run sharded pub sub tests |
PavelPashov
changed the title
|
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- secret-detection-trufflehog
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- secret-detection-trufflehog
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
PavelPashov
changed the title
nkaradzhov
left a comment
nkaradzhov
left a comment
There was a problem hiding this comment.
CLGTM, left couple totally unimportant nits
| this.onEnd = () => { | ||
| this.started = false; | ||
| this.emitter.emit("-node", this.instance, this.nodeKey); | ||
| }; | ||
|
|
||
| this.onError = (error: Error) => { | ||
| this.emitter.emit("nodeError", error, this.nodeKey); | ||
| }; | ||
|
|
||
| this.onMoved = () => { | ||
| this.emitter.emit("moved"); | ||
| }; |
There was a problem hiding this comment.
those all can be just instance arrow fns like this:
class Foo {
onEnd = () => {}
}this way we can remove the declarations
| this.instance.off("end", this.onEnd); | ||
| this.instance.off("error", this.onError); | ||
| this.instance.off("moved", this.onMoved); |
There was a problem hiding this comment.
its also ok to say this.instance.removeAllListeners(). I think it should be safe, because noone else uses the instance, so no danger of removing some listeners that are not ours
3 participants
No description provided.